Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add create cursor util #9086

Merged
merged 3 commits into from
Dec 17, 2024
Merged

fix: add create cursor util #9086

merged 3 commits into from
Dec 17, 2024

Conversation

magrinj
Copy link
Member

@magrinj magrinj commented Dec 16, 2024

Followup of #9053

@magrinj magrinj marked this pull request as ready for review December 16, 2024 14:08
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Adds a new cursor creation utility with tests to handle record positioning in Apollo cache, supporting the fix for record group insertion behavior.

  • Added createCursor.ts utility in /packages/twenty-front/src/modules/apollo/utils/ to handle base64 encoding of record IDs and positions
  • Added comprehensive test suite in createCursor.test.ts covering edge cases like position=0 and missing IDs
  • Refactored triggerCreateRecordsOptimisticEffect.ts to use the new cursor utility for consistent cursor generation
  • Improved error handling by adding explicit checks for missing record IDs

3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

@charlesBochet charlesBochet merged commit 1f4d135 into main Dec 17, 2024
22 checks passed
@charlesBochet charlesBochet deleted the fix/create-cursor-util branch December 17, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants