-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add create cursor util #9086
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Adds a new cursor creation utility with tests to handle record positioning in Apollo cache, supporting the fix for record group insertion behavior.
- Added
createCursor.ts
utility in/packages/twenty-front/src/modules/apollo/utils/
to handle base64 encoding of record IDs and positions - Added comprehensive test suite in
createCursor.test.ts
covering edge cases like position=0 and missing IDs - Refactored
triggerCreateRecordsOptimisticEffect.ts
to use the new cursor utility for consistent cursor generation - Improved error handling by adding explicit checks for missing record IDs
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/apollo/utils/__tests__/createCursor.test.ts
Outdated
Show resolved
Hide resolved
Weiko
reviewed
Dec 16, 2024
Weiko
reviewed
Dec 16, 2024
Weiko
reviewed
Dec 17, 2024
Weiko
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #9053